Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25509 )
Change subject: Add i945G based mainboard
......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25509/23/src/mainboard/nec/945g-m4/...
File src/mainboard/nec/945g-m4/acpi/video.asl:
https://review.coreboot.org/c/coreboot/+/25509/23/src/mainboard/nec/945g-m4/...
PS23, Line 16:
: // Brightness write
: Method (BRTW, 1, Serialized)
: {
: // TODO
: }
:
: // Hot Key Display Switch
: Method (HKDS, 1, Serialized)
: {
: // TODO
: }
:
: // Lid Switch Display Switch
: Method (LSDS, 1, Serialized)
: {
: // TODO
: }
:
: // Brightness Notification
: Method(BRTN,1,Serialized)
: {
: // TODO (no displays defined yet)
: }
This file is not even included it seems...
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5398b990c26d087afb20e4b1028a7a1cad4b3ee3
Gerrit-Change-Number: 25509
Gerrit-PatchSet: 36
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 08 Feb 2020 22:36:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment