Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63793 )
Change subject: ec/google/chromeec/ec_acpi: Add retimer handle to Type C conn
......................................................................
Patch Set 1:
(2 comments)
File src/acpi/acpigen_usb.c:
https://review.coreboot.org/c/coreboot/+/63793/comment/f6566f61_11739337
PS1, Line 109: retimer-switch
As long as that is the only change expected, I don't foresee that being a problem.
Ack
File src/include/acpi/acpigen_usb.h:
https://review.coreboot.org/c/coreboot/+/63793/comment/709865c6_c57f220f
PS1, Line 46: * various endpoints (xHCI, DP, etc.) on the SoC.
copy pasta ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0480b08c6d6a7562cca57192e49b8ea2a33b51e
Gerrit-Change-Number: 63793
Gerrit-PatchSet: 1
Gerrit-Owner: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 02 May 2022 19:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Prashant Malani
pmalani@chromium.org
Gerrit-MessageType: comment