Attention is currently required from: David Wu, Tim Wawrzynczak, Nick Vaccaro.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64199 )
Change subject: mb/google/brya/variants/osiris: Init devicetree for osiris
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/osiris/variant.c:
https://review.coreboot.org/c/coreboot/+/64199/comment/cc0b651f_b26a9ad6
PS2, Line 5: #include <baseboard/variants.h>
nit: in alphabet order.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64199
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie69957b39b5c299846c64f67fb29207cf858e50e
Gerrit-Change-Number: 64199
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 11 May 2022 05:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment