Attention is currently required from: Chen, Gang C, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin L Roth, Patrick Rudolph, Shuo Liu, TangYiwei, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81318?usp=email )
Change subject: soc/intel/xeon_sp/gnr: Add IIO config utils
......................................................................
Patch Set 31:
(4 comments)
File src/soc/intel/xeon_sp/gnr/include/soc/iio.h:
https://review.coreboot.org/c/coreboot/+/81318/comment/b2dba11f_337db246 :
PS31, Line 12: typedef
Coding style does not allow typedefs for structs.
https://review.coreboot.org/c/coreboot/+/81318/comment/3ae4f712_bcace673 :
PS31, Line 88: rsv1, rsv2, rsv3, rsv4,
what are these?
https://review.coreboot.org/c/coreboot/+/81318/comment/14feb210_308bd196 :
PS31, Line 92: vaddr
Add () around each argument
File src/soc/intel/xeon_sp/gnr/soc_iio.c:
https://review.coreboot.org/c/coreboot/+/81318/comment/95a00df5_410f3419 :
PS31, Line 23: memset(&iio_upd_hob, 0, sizeof(iio_upd_hob));
the static initialization is already 0 by default
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7146761db6f73a0c4b0d31b010c0d30a42bf690
Gerrit-Change-Number: 81318
Gerrit-PatchSet: 31
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 09 Apr 2024 13:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment