Attention is currently required from: Felix Singer, Subrata Banik, Nick Vaccaro, Andrey Petrov, Patrick Rudolph, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60402 )
Change subject: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional
......................................................................
Patch Set 7: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60402/comment/ba3a0a8b_2c2e9c97
PS7, Line 10: support
`supports`
https://review.coreboot.org/c/coreboot/+/60402/comment/c368ffe9_14dd4a2f
PS7, Line 17: implementation
`implementations`
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/60402/comment/d8cf1709_b546eb00
PS7, Line 307: support
nit, here and below:
`supports`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia95e9ec25ae797f2ac8e1c74145cf21e59867d64
Gerrit-Change-Number: 60402
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 01 Jan 2022 22:14:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment