[M] Change in coreboot[master]: soc/intel/common: Order the different types of cores based on APIC IDs
Attention is currently required from: Subrata Banik, Paul Menzel, Kyösti Mälkki, Elyes Haouas.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 )
Change subject: soc/intel/common: Order the different types of cores based on APIC IDs ......................................................................
Patch Set 17:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72132/comment/119bae64_05fb82d5 PS15, Line 24: Existing code presents mix of different cores to OS and causes CPU load : balancing and power/performance impact.
Why? What ordering does the OS require? Maybe reference the kernel source code.
Please refer the patches for media dynamic cgroup:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3963893 https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3963893
As part of media dynamic cgroup, the policy assign e-cores whose ID starts from CPUID#4 to 7 (https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3562269/34...) to the group after calculating the P-CORES and E-CORES in the system. Also, the system assumes the P/E-cores are arranged in sequence.
Commit Message:
https://review.coreboot.org/c/coreboot/+/72132/comment/8b5926fc_3033f15c PS16, Line 23: Existing code presents mix of different cores to OS and causes CPU load
Please add a blank line above.
Done
-
Sridhar Siricilla (Code Review)