Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Michał Kopeć, Angel Pons, Werner Zeh.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68945 )
Change subject: soc/intel/alderlake: Hook up the OC watchdog
......................................................................
Patch Set 16:
(1 comment)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/68945/comment/458c360f_ccca0ea7
PS16, Line 169: CONFIG_SOC_INTEL_COMMON_OC_WDT_TIMEOUT_SECONDS
I'm more afraid that without having a detailed understanding if the user ended up setting a lower value than required, then it would result into the WDT expiry, hence asking if setting up a static value is better rather running into an issue (with an assumption that kernel can reconfigure it).
Your concerns are subject to patch CB:68944 where the minimal timeout is defined as Kconfig range. Can we shift this discussion there?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c2c640d48b7e03ad8cd8d6cdf6aac447e93cd86
Gerrit-Change-Number: 68945
Gerrit-PatchSet: 16
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 28 Mar 2023 09:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment