Attention is currently required from: SRIDHAR SIRICILLA, Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................
Patch Set 18: Code-Review-1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74005/comment/572343dd_05dd60e8
PS1, Line 10: version details of ISHC.
Can you indicate the purpose to retreive the version details of ISHC?
Patchset:
PS18:
Since there are open comments, I request not to merge the patch.
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74005/comment/31167d21_831d4dd7
PS18, Line 1226: .group_id = MKHI_GROUP_ID_GEN,
: .command = MKHI_BUP_COMMON_GET_BOOT_PARTITION_INFO,
From the command naming MKHI_BUP_COMMON_GET_BOOT_PARTITION_INFO, it is belong to BUP_COMMON group id, but group ID GEN is being used.
Do you refer below group and command info?
.group_id = MKHI_GEN_GROUP_ID,
.command = GEN_GET_IMAGE_FW_VERSION,
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
Gerrit-Change-Number: 74005
Gerrit-PatchSet: 18
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: SRIDHAR SIRICILLA
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Fri, 07 Apr 2023 11:18:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment