Change in coreboot[master]: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence
Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence
According Goodix spec, update setting for the power sequence.
BUG=b:176270381 BRANCH=zork TEST=measure the waveform is meet the Goodix touchscreen spec.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I687ffa2eb13a9ddecb3045c5e1540b94417329ec --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48907/1
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index a3c2c97..f484e9a 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -108,7 +108,7 @@ register "generic.reset_off_delay_ms" = "2" register "generic.reset_delay_ms" = "20" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" - register "generic.stop_delay_ms" = "100" + register "generic.stop_delay_ms" = "160" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@9 PS1, Line 9: update setting for the power sequence. Please be specific:
… increase the stop delay time from 100 ms to 160 ms.
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@9 PS1, Line 9: spec Please note name and revision.
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@10 PS1, Line 10: Does the touchscreen sometimes not work? Please add the problem description to the commit message.
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@13 PS1, Line 13: TEST=measure the waveform is meet the Goodix touchscreen spec. Maybe:
Confirm the measured waveform complies with Goodix touchscreen spec.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48907
to look at the new patch set (#2).
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence
According Goodix GT7375P Programming Guide_Rev.0.6, increase the stop delay time from 100 ms to 160 ms. The power sequence is not meet with the latest guide_rev.0.6.
BUG=b:176270381 BRANCH=zork TEST=Confirm the measured waveform complies with Goodix touchscreen spec.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I687ffa2eb13a9ddecb3045c5e1540b94417329ec --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48907/2
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 2:
(4 comments)
Thank you for the comment. Updated the commit message.
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@9 PS1, Line 9: spec
Please note name and revision.
Done
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@9 PS1, Line 9: update setting for the power sequence.
Please be specific: […]
Done
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@10 PS1, Line 10:
Does the touchscreen sometimes not work? Please add the problem description to the commit message.
Done
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@13 PS1, Line 13: TEST=measure the waveform is meet the Goodix touchscreen spec.
Maybe: […]
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48907/2//COMMIT_MSG@9 PS2, Line 9: extra space here.
Hello Sam McNally, build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Eric Peers, Rob Barnes, Ivy Jian, EricR Lai, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48907
to look at the new patch set (#3).
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence
According Goodix GT7375P Programming Guide_Rev.0.6, increase the stop delay time from 100 ms to 160 ms. The power sequence is not meet with the latest guide_rev.0.6.
BUG=b:176270381 BRANCH=zork TEST=Confirm the measured waveform complies with Goodix touchscreen spec.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I687ffa2eb13a9ddecb3045c5e1540b94417329ec --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48907/3
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48907/2//COMMIT_MSG@9 PS2, Line 9:
extra space here.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48907/3//COMMIT_MSG@11 PS3, Line 11: meet met
Hello Sam McNally, build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Paul Menzel, Eric Peers, Rob Barnes, Ivy Jian, EricR Lai, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48907
to look at the new patch set (#4).
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence
According Goodix GT7375P Programming Guide_Rev.0.6, increase the stop delay time from 100 ms to 160 ms. The power sequence is not met with the latest guide_rev.0.6.
BUG=b:176270381 BRANCH=zork TEST=Confirm the measured waveform complies with Goodix touchscreen spec.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I687ffa2eb13a9ddecb3045c5e1540b94417329ec --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48907/4
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48907/3//COMMIT_MSG@11 PS3, Line 11: meet
met
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4: Code-Review+2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4: Code-Review+1
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4:
Hi Google,
Would you help to merge the CL? Thank you.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v... PS4, Line 111: 160 Doesn't the guide say that this should be 180?
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v... PS4, Line 111: 160
Doesn't the guide say that this should be 180?
According to p.15 of spec Programming Guide_Rev.0.6, the time interval (T5) should be 180 ms between "reset pin is high" and "host read firmware version". Therefore, I set "reset delay 20 ms + stop delay 160 ms = 180 ms" to fit the time interval.
spec ref: https://partnerissuetracker.corp.google.com/issues/176270381#comment5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v... PS4, Line 111: 160
According to p.15 of spec Programming Guide_Rev.0. […]
SG. Thanks!
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 4:
Hi Google,
Would you help to merge the CL? Thank you.
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence
According Goodix GT7375P Programming Guide_Rev.0.6, increase the stop delay time from 100 ms to 160 ms. The power sequence is not met with the latest guide_rev.0.6.
BUG=b:176270381 BRANCH=zork TEST=Confirm the measured waveform complies with Goodix touchscreen spec.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I687ffa2eb13a9ddecb3045c5e1540b94417329ec Reviewed-on: https://review.coreboot.org/c/coreboot/+/48907 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve EricR Lai: Looks good to me, approved Kangheui Won: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index a3c2c97..f484e9a 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -108,7 +108,7 @@ register "generic.reset_off_delay_ms" = "2" register "generic.reset_delay_ms" = "20" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" - register "generic.stop_delay_ms" = "100" + register "generic.stop_delay_ms" = "160" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01"
-
EricR Lai (Code Review) -
Frank Wu (Code Review)
-
Furquan Shaikh (Code Review)
-
Kangheui Won (Code Review)
-
Paul Menzel (Code Review)
-
Rob Barnes (Code Review)