Change in coreboot[master]: mb/google/volteer: fw_config: Add fields for keyboard features

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45346 )

Change subject: mb/google/volteer: fw_config: Add fields for keyboard features
......................................................................

mb/google/volteer: fw_config: Add fields for keyboard features

Add newly defined fields for presence of keyboard backlight and
number pad to the firmware configuration table.

We don't have a need to use these in coreboot (yet) but this
keeps the bit definitions in sync.

BUG=b:166707536
TEST=abuild -t google/volteer

Change-Id: I066e445f7d0be056e45737d2c538be1850ae85aa
Signed-off-by: Duncan Laurie 
---
M src/mainboard/google/volteer/variants/baseboard/devicetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45346/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index 582f44a..7b018b2 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -22,6 +22,14 @@
    	option LTE_ABSENT 0
    	option LTE_PRESENT 1
    end
+	field KB_BL 14
+		option KB_BL_ABSENT 0
+		option KB_BL_PRESENT 1
+	end
+	field NUMPAD 15
+		option NUMPAD_ABSENT 0
+		option NUMPAD_PRESENT 1
+	end
    field DB_SD 16 19
    	option SD_ABSENT 0
    	option SD_GL9755S 1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45346 )

Change subject: mb/google/volteer: fw_config: Add fields for keyboard features
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45346 )

Change subject: mb/google/volteer: fw_config: Add fields for keyboard features
......................................................................

mb/google/volteer: fw_config: Add fields for keyboard features

Add newly defined fields for presence of keyboard backlight and
number pad to the firmware configuration table.

We don't have a need to use these in coreboot (yet) but this
keeps the bit definitions in sync.

BUG=b:166707536
TEST=abuild -t google/volteer

Change-Id: I066e445f7d0be056e45737d2c538be1850ae85aa
Signed-off-by: Duncan Laurie 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45346
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/volteer/variants/baseboard/devicetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index 582f44a..7b018b2 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -22,6 +22,14 @@
    	option LTE_ABSENT 0
    	option LTE_PRESENT 1
    end
+	field KB_BL 14
+		option KB_BL_ABSENT 0
+		option KB_BL_PRESENT 1
+	end
+	field NUMPAD 15
+		option NUMPAD_ABSENT 0
+		option NUMPAD_PRESENT 1
+	end
    field DB_SD 16 19
    	option SD_ABSENT 0
    	option SD_GL9755S 1

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45346 )

Change subject: mb/google/volteer: fw_config: Add fields for keyboard features
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/20166
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/20165
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/20164
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/20163
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/20162
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/20170
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/20169
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/20168
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/20167

Please note: This test is under development and might not be accurate at all!