Change in coreboot[master]: mb/prodrive/hermes: Wrap UART driver by PCI device - coreboot-gerrit

5 Dec 2020


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48293 )
Change subject: mb/prodrive/hermes: Wrap UART driver by PCI device
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48293/3/src/mainboard/prodrive/herm... 
File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48293/3/src/mainboard/prodrive/herm... 
PS3, Line 177: 				device pci 00.0 on end
...
this device doesn't exist
`device generic 0 on end` would be correct, see CB:46865 for example
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I298247276ec95b2f599f1fcd399550a51b63aff1
Gerrit-Change-Number: 48293
Gerrit-PatchSet: 4
Gerrit-Owner:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 05 Dec 2020 13:05:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-MessageType: comment