[M] Change in coreboot[master]: mb/google/myst: Add eSPI configuration - coreboot-gerrit

18 Apr 2023


      Attention is currently required from: Raul Rangel, Jon Murphy, Felix Held, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74110 )
Change subject: mb/google/myst: Add eSPI configuration
......................................................................
Patch Set 30: -Code-Review
(1 comment)
File src/mainboard/google/myst/bootblock.c:
https://review.coreboot.org/c/coreboot/+/74110/comment/9c97bc91_07fc6705 
PS30, Line 14: }
...
looking at the espi_gpio_table, you're using spi1 for espi, so you're missing the  espi_switch_to_sp […]
+1. Thanks for catching that.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74110
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b40adec78d4e0b596596fa6e2951c79bd3bd8c7
Gerrit-Change-Number: 74110
Gerrit-PatchSet: 30
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Tue, 18 Apr 2023 05:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment