Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40752 )
Change subject: mb/amd/padmelon: Remove PS/2 keyboard driver selection ......................................................................
mb/amd/padmelon: Remove PS/2 keyboard driver selection
Most payloads, like GRUB, SeaBIOS and Linux, are able to initialize the PS/2 keyboard themselves, so coreboot does not need to initialize it. Therefore, this option should not be hard-coded for the mainboard, and be left for the user to select.
Change-Id: Ibfb7efa22c525e60399afc198af6632330faaac3 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/amd/padmelon/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/40752/1
diff --git a/src/mainboard/amd/padmelon/Kconfig b/src/mainboard/amd/padmelon/Kconfig index 98753cf..300a300 100644 --- a/src/mainboard/amd/padmelon/Kconfig +++ b/src/mainboard/amd/padmelon/Kconfig @@ -20,7 +20,6 @@ select AMD_APU_PKG_FP4 select BOARD_ROMSIZE_KB_8192 select DRIVERS_I2C_GENERIC - select DRIVERS_PS2_KEYBOARD select HAVE_ACPI_TABLES select GFXUMA select STONEYRIDGE_LEGACY_FREE
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40752 )
Change subject: mb/amd/padmelon: Remove PS/2 keyboard driver selection ......................................................................
Patch Set 1: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40752 )
Change subject: mb/amd/padmelon: Remove PS/2 keyboard driver selection ......................................................................
mb/amd/padmelon: Remove PS/2 keyboard driver selection
Most payloads, like GRUB, SeaBIOS and Linux, are able to initialize the PS/2 keyboard themselves, so coreboot does not need to initialize it. Therefore, this option should not be hard-coded for the mainboard, and be left for the user to select.
Change-Id: Ibfb7efa22c525e60399afc198af6632330faaac3 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40752 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/amd/padmelon/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/amd/padmelon/Kconfig b/src/mainboard/amd/padmelon/Kconfig index 98753cf..300a300 100644 --- a/src/mainboard/amd/padmelon/Kconfig +++ b/src/mainboard/amd/padmelon/Kconfig @@ -20,7 +20,6 @@ select AMD_APU_PKG_FP4 select BOARD_ROMSIZE_KB_8192 select DRIVERS_I2C_GENERIC - select DRIVERS_PS2_KEYBOARD select HAVE_ACPI_TABLES select GFXUMA select STONEYRIDGE_LEGACY_FREE
-
Marshall Dawson (Code Review) -
Matt DeVillier (Code Review)
-
Paul Menzel (Code Review)