Change in coreboot[master]: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters f...
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )
Change subject: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46676/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46676/12//COMMIT_MSG@7 PS12, Line 7: UPSTREAM: Remove here; this will get added when the patch is downstreamed into the chromium repo
https://review.coreboot.org/c/coreboot/+/46676/12/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/12/src/mainboard/google/volte... PS12, Line 26: # Default DPTF Policy for all Volteer boards if not overridden This comment isn't true here
https://review.coreboot.org/c/coreboot/+/46676/12/src/mainboard/google/volte... PS12, Line 31: TEMP_PCT(57, 90), : TEMP_PCT(47, 80), : TEMP_PCT(40, 70), : TEMP_PCT(36, 60), : TEMP_PCT(34, 50), : TEMP_PCT(30, 40),}}}" Won't the fan be running constantly at these thresholds?
https://review.coreboot.org/c/coreboot/+/46676/12/src/mainboard/google/volte... PS12, Line 74: Did you intend to leave out the setting for the 500mA charging rate?, i.e. ``` [3] = { 8, 500 }}" ```
-
Tim Wawrzynczak (Code Review)