Change in coreboot[master]: Helios: Set the reset delay for Goodix touchscreen to 120ms

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Shelley Chen (Code Review)

6 Nov 2019 6 Nov '19

7:14 p.m.

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36655 )

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Helios: Set the reset delay for Goodix touchscreen to 120ms

With the 0.71586+ Goodix FW, we can reduce the reset delay from 500ms to 120ms. We should do the change in coreboot device tree after we ensure Helios DVT build is flashed with 0.71586+ Goodix FW.

BUG=b:142316026 BRANCH=None TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/36655/1

diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 8c90928..08cbe1a 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -103,7 +103,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "500" + register "generic.reset_delay_ms" = "120" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Subrata Banik (Code Review)

6 Nov 6 Nov

9:50 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36655 )

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Gerrit-Change-Number: 36655 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 Nov 2019 04:50:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

7 Nov 7 Nov

9:54 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36655 )

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Patch Set 1:

Shelly, can we merge this ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Gerrit-Change-Number: 36655 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 08 Nov 2019 04:54:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shelley Chen (Code Review)

10:13 p.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36655 )

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Patch Set 1:

Philip, are we good with the goodix fw?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Gerrit-Change-Number: 36655 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 08 Nov 2019 05:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Philip Chen (Code Review)

8 Nov 8 Nov

10:26 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36655 )

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Patch Set 1:

Can we do the change for variants/hatch/overridetree.cb too? Because the new variants will mostly be copied from variants/hatch/overridetree.cb.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Gerrit-Change-Number: 36655 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Assignee: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Philip Chen philipchen@chromium.org Gerrit-Comment-Date: Fri, 08 Nov 2019 17:26:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shelley Chen (Code Review)

11:54 a.m.

Hello Kane Chen, Subrata Banik, Philip Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36655

to look at the new patch set (#2).

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Helios: Set the reset delay for Goodix touchscreen to 120ms

With the 0.71586+ Goodix FW, we can reduce the reset delay from 500ms to 120ms. We should do the change in coreboot device tree after we ensure Helios DVT build is flashed with 0.71586+ Goodix FW.

BUG=b:142316026 BRANCH=None TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/36655/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Gerrit-Change-Number: 36655 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Assignee: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Philip Chen philipchen@chromium.org Gerrit-MessageType: newpatchset

Philip Chen (Code Review)

4:12 p.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36655 )

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Gerrit-Change-Number: 36655 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Assignee: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Philip Chen philipchen@chromium.org Gerrit-Comment-Date: Fri, 08 Nov 2019 23:12:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11 Nov 11 Nov

3:28 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36655 )

Change subject: Helios: Set the reset delay for Goodix touchscreen to 120ms ......................................................................

Helios: Set the reset delay for Goodix touchscreen to 120ms

With the 0.71586+ Goodix FW, we can reduce the reset delay from 500ms to 120ms. We should do the change in coreboot device tree after we ensure Helios DVT build is flashed with 0.71586+ Goodix FW.

BUG=b:142316026 BRANCH=None TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36655 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philip Chen philipchen@google.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Philip Chen: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index bc6aa11..75c14ef 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -98,7 +98,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "500" + register "generic.reset_delay_ms" = "120" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" register "generic.enable_delay_ms" = "12" diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 04bf6c1..94639dc 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -103,7 +103,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "500" + register "generic.reset_delay_ms" = "120" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"

-- To view, visit https://review.coreboot.org/c/coreboot/+/36655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I000ee4ea84c598b437992f1000f6e5b561cae605 Gerrit-Change-Number: 36655 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Assignee: Philip Chen philipchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Philip Chen philipchen@chromium.org Gerrit-MessageType: merged

2011

days inactive

2015

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Patrick Georgi (Code Review)
Philip Chen (Code Review)
Shelley Chen (Code Review)
Subrata Banik (Code Review)