Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50052 )
Change subject: Revert "soc/amd/picasso: Change GPIO _HID to AMDI0030" ......................................................................
Revert "soc/amd/picasso: Change GPIO _HID to AMDI0030"
This reverts commit 75f6ab35ffefec72e343175686d7ef45b30b0939.
Reason for revert: The 5.4 Linux kernel is not configured for AMDI0030. This causes an issue where the WP pin is not recognized.
BUG=b:179320024 TEST=WP pin shows up properly in crossystem after reverting this change.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I0850fd085b5ee70522752633900f69d4d3732321 Reviewed-on: https://review.coreboot.org/c/coreboot/+/50052 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/include/soc/gpio.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/include/soc/gpio.h b/src/soc/amd/picasso/include/soc/gpio.h index f76c446..0f4507c 100644 --- a/src/soc/amd/picasso/include/soc/gpio.h +++ b/src/soc/amd/picasso/include/soc/gpio.h @@ -3,7 +3,7 @@ #ifndef AMD_PICASSO_GPIO_H #define AMD_PICASSO_GPIO_H
-#define GPIO_DEVICE_NAME "AMDI0030" +#define GPIO_DEVICE_NAME "AMD0030" #define GPIO_DEVICE_DESC "GPIO Controller"
#ifndef __ACPI__