Attention is currently required from: Jason Glenesk, Raul Rangel, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75334 )
Change subject: soc/amd/common/psp_verstage: Copy unsigned PSP verstage binary
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75334/comment/73db8e54_f9e2e504
PS1, Line 10: If a signed PSP verstage binary is supplied
: while building amdfw*.rom, then it is dropped.
this part is unclear to me. Why would we also be building the unsigned verstage if a signed binary is being supplied?
https://review.coreboot.org/c/coreboot/+/75334/comment/248f2a44_24a1661e
PS1, Line 12: verstage binary always so that it can be used for signing directly from
: the CI build infrastructure instead of a locally built binary.
so is the goal here simply to persist the unsigned binary so it can be signed later? If so, will the unsigned binary in amdfw be swapped with the signed binary at that time?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If797dcfd20aa2991f3517904ef862406b9b9875c
Gerrit-Change-Number: 75334
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 18 May 2023 16:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment