Attention is currently required from: Kyösti Mälkki.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55189 )
Change subject: cpu/x86/lapic: Redo DEBUG_HALT_SELF
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/x86/lapic/lapic_cpu_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120865):
https://review.coreboot.org/c/coreboot/+/55189/comment/615bc363_2081571c
PS3, Line 321: #define dprintk(LEVEL, args...) do { printk(LEVEL, ##args); } while (0)
Single statement macros should not use a do {} while (0) loop
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e42519d5bcee95970d366fd64923de874098172
Gerrit-Change-Number: 55189
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 06 Jun 2021 14:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment