Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant ......................................................................
Patch Set 5:
(4 comments)
@Nico: As far as I understand UVSCC applies to the second flash chip and should be set to 0 on boards that only have one flash chip, correct ?
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0
X1 does not have Expresscard slot.
Ack
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 79: 0x2005
No, it has one flash chip, same as x220.
As far as I understand UVSCC only applies to the "upper" aka second flash chip.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 104: on
a wlan card slot, and a USB3 controller.
in that case you have three unused enabled pcie slots, which should be set to "off".
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 173: has_bdc_detection
How to check whether BDC detection works?
enable has_bdc_detection and set bdc_gpio_num=54 and test if BDC is still detected by Lenovo's H8 code. it prints "H8: BDC ..."
-
Patrick Rudolph (Code Review)