Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38158 )
Change subject: drivers/i2c/lm63: Drop unused hardware monitor support ......................................................................
drivers/i2c/lm63: Drop unused hardware monitor support
Change-Id: Ie72f66a8fc93e4994df5463b8ff19ba118c88389 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- D src/drivers/i2c/lm63/Kconfig D src/drivers/i2c/lm63/Makefile.inc D src/drivers/i2c/lm63/lm63.c 3 files changed, 0 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/38158/1
diff --git a/src/drivers/i2c/lm63/Kconfig b/src/drivers/i2c/lm63/Kconfig deleted file mode 100644 index 120ee0d..0000000 --- a/src/drivers/i2c/lm63/Kconfig +++ /dev/null @@ -1,2 +0,0 @@ -config DRIVERS_I2C_LM63 - bool diff --git a/src/drivers/i2c/lm63/Makefile.inc b/src/drivers/i2c/lm63/Makefile.inc deleted file mode 100644 index bd1c7ef..0000000 --- a/src/drivers/i2c/lm63/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-$(CONFIG_DRIVERS_I2C_LM63) += lm63.c diff --git a/src/drivers/i2c/lm63/lm63.c b/src/drivers/i2c/lm63/lm63.c deleted file mode 100644 index 3da38d8..0000000 --- a/src/drivers/i2c/lm63/lm63.c +++ /dev/null @@ -1,47 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <device/device.h> -#include <device/smbus.h> - -static void lm63_init(struct device *dev) -{ - int result; - if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) { - if (ops_smbus_bus(get_pbus_smbus(dev))) { - if (dev->bus->dev->path.type == DEVICE_PATH_I2C) - smbus_set_link(dev); // it is under mux - result = smbus_read_byte(dev, 0x03); -// result &= ~0x04; - result |= 0x04; - smbus_write_byte(dev, 0x03, result & 0xff); // config lm63 - } - } -} - -static struct device_operations lm63_operations = { - .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, - .init = lm63_init, -}; - -static void enable_dev(struct device *dev) -{ - dev->ops = &lm63_operations; -} - -struct chip_operations drivers_i2c_lm63_ops = { - CHIP_NAME("National Semiconductor LM63") - .enable_dev = enable_dev, -};
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38158 )
Change subject: drivers/i2c/lm63: Drop unused hardware monitor support ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38158 )
Change subject: drivers/i2c/lm63: Drop unused hardware monitor support ......................................................................
drivers/i2c/lm63: Drop unused hardware monitor support
Change-Id: Ie72f66a8fc93e4994df5463b8ff19ba118c88389 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38158 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- D src/drivers/i2c/lm63/Kconfig D src/drivers/i2c/lm63/Makefile.inc D src/drivers/i2c/lm63/lm63.c 3 files changed, 0 insertions(+), 50 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/drivers/i2c/lm63/Kconfig b/src/drivers/i2c/lm63/Kconfig deleted file mode 100644 index 120ee0d..0000000 --- a/src/drivers/i2c/lm63/Kconfig +++ /dev/null @@ -1,2 +0,0 @@ -config DRIVERS_I2C_LM63 - bool diff --git a/src/drivers/i2c/lm63/Makefile.inc b/src/drivers/i2c/lm63/Makefile.inc deleted file mode 100644 index bd1c7ef..0000000 --- a/src/drivers/i2c/lm63/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-$(CONFIG_DRIVERS_I2C_LM63) += lm63.c diff --git a/src/drivers/i2c/lm63/lm63.c b/src/drivers/i2c/lm63/lm63.c deleted file mode 100644 index 3da38d8..0000000 --- a/src/drivers/i2c/lm63/lm63.c +++ /dev/null @@ -1,47 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <device/device.h> -#include <device/smbus.h> - -static void lm63_init(struct device *dev) -{ - int result; - if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) { - if (ops_smbus_bus(get_pbus_smbus(dev))) { - if (dev->bus->dev->path.type == DEVICE_PATH_I2C) - smbus_set_link(dev); // it is under mux - result = smbus_read_byte(dev, 0x03); -// result &= ~0x04; - result |= 0x04; - smbus_write_byte(dev, 0x03, result & 0xff); // config lm63 - } - } -} - -static struct device_operations lm63_operations = { - .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, - .init = lm63_init, -}; - -static void enable_dev(struct device *dev) -{ - dev->ops = &lm63_operations; -} - -struct chip_operations drivers_i2c_lm63_ops = { - CHIP_NAME("National Semiconductor LM63") - .enable_dev = enable_dev, -};
-
Kyösti Mälkki (Code Review) -
Nico Huber (Code Review)