Change in coreboot[master]: util/autoport: Always output quoted Kconfig string

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/45463

to review the following change.

Change subject: util/autoport: Always output quoted Kconfig string
......................................................................

util/autoport: Always output quoted Kconfig string

Change-Id: I2076af9c70b626673a83af9abf464d376cda711b
Signed-off-by: Iru Cai 
---
M util/autoport/main.go
1 file changed, 1 insertion(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/45463/1

diff --git a/util/autoport/main.go b/util/autoport/main.go
index b2334e2..1a9050a 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -104,7 +104,6 @@
 var KconfigBool map[string]bool = map[string]bool{}
 var KconfigComment map[string]string = map[string]string{}
 var KconfigString map[string]string = map[string]string{}
-var KconfigStringUnquoted map[string]string = map[string]string{}
 var KconfigHex map[string]uint32 = map[string]uint32{}
 var KconfigInt map[string]int = map[string]int{}
 var ROMSizeKB = 0
@@ -571,21 +570,6 @@
    }

keys = nil
-	for name, _ := range KconfigStringUnquoted {
-		keys = append(keys, name)
-	}
-
-	sort.Strings(keys)
-
-	for _, name := range keys {
-		fmt.Fprintf(kc, `
-config %s%s
-	string
-	default %s
-`, name, makeComment(name), KconfigStringUnquoted[name])
-	}
-
-	keys = nil
    for name, _ := range KconfigString {
    	keys = append(keys, name)
    }
@@ -730,7 +714,7 @@
    ctx.MoboID = ctx.SaneVendor + "/" + sanitize(ctx.Model)
    ctx.KconfigName = "BOARD_" + strings.ToUpper(ctx.SaneVendor+"_"+sanitize(ctx.Model))
    ctx.BaseDirectory = *FlagOutDir + MoboDir + ctx.MoboID
-	KconfigStringUnquoted["MAINBOARD_DIR"] = ctx.MoboID
+	KconfigString["MAINBOARD_DIR"] = ctx.MoboID
    KconfigString["MAINBOARD_PART_NUMBER"] = ctx.Model

os.MkdirAll(ctx.BaseDirectory, 0700)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45463 )

Change subject: util/autoport: Always output quoted Kconfig string
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45463 )

Change subject: util/autoport: Always output quoted Kconfig string
......................................................................

util/autoport: Always output quoted Kconfig string

Change-Id: I2076af9c70b626673a83af9abf464d376cda711b
Signed-off-by: Iru Cai 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45463
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M util/autoport/main.go
1 file changed, 1 insertion(+), 17 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/util/autoport/main.go b/util/autoport/main.go
index b2334e2..1a9050a 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -104,7 +104,6 @@
 var KconfigBool map[string]bool = map[string]bool{}
 var KconfigComment map[string]string = map[string]string{}
 var KconfigString map[string]string = map[string]string{}
-var KconfigStringUnquoted map[string]string = map[string]string{}
 var KconfigHex map[string]uint32 = map[string]uint32{}
 var KconfigInt map[string]int = map[string]int{}
 var ROMSizeKB = 0
@@ -571,21 +570,6 @@
    }

keys = nil
-	for name, _ := range KconfigStringUnquoted {
-		keys = append(keys, name)
-	}
-
-	sort.Strings(keys)
-
-	for _, name := range keys {
-		fmt.Fprintf(kc, `
-config %s%s
-	string
-	default %s
-`, name, makeComment(name), KconfigStringUnquoted[name])
-	}
-
-	keys = nil
    for name, _ := range KconfigString {
    	keys = append(keys, name)
    }
@@ -730,7 +714,7 @@
    ctx.MoboID = ctx.SaneVendor + "/" + sanitize(ctx.Model)
    ctx.KconfigName = "BOARD_" + strings.ToUpper(ctx.SaneVendor+"_"+sanitize(ctx.Model))
    ctx.BaseDirectory = *FlagOutDir + MoboDir + ctx.MoboID
-	KconfigStringUnquoted["MAINBOARD_DIR"] = ctx.MoboID
+	KconfigString["MAINBOARD_DIR"] = ctx.MoboID
    KconfigString["MAINBOARD_PART_NUMBER"] = ctx.Model

os.MkdirAll(ctx.BaseDirectory, 0700)