Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of an error message ......................................................................
drivers/mrc_cache: Reduce severity of an error message
On autogenerated FMAPs, there's no `UNIFIED_MRC_CACHE` region. The current code will print a spurious error message about it, though.
Reduce the log level to BIOS_INFO to avoid confusion.
Change-Id: I0961bb2a7d2d81dc5c0d28f6e6c29b320421fc3e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45076/1
diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index 0e42120..00652ac 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -480,7 +480,7 @@ return 0;
if (lookup_region_by_name(name, ®ion) < 0) { - printk(BIOS_ERR, "MRC: Could not find region '%s'\n", name); + printk(BIOS_INFO, "MRC: Could not find region '%s'\n", name); return -1; }
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of an error message ......................................................................
Patch Set 1: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of an error message ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of an error message ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45076/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45076/1//COMMIT_MSG@7 PS1, Line 7: drivers/mrc_cache: Reduce severity of an error message Maybe:
Reduce severity of nonexistent region log message
Hello build bot (Jenkins), Christian Walter, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45076
to look at the new patch set (#2).
Change subject: drivers/mrc_cache: Reduce severity of non-existent log message ......................................................................
drivers/mrc_cache: Reduce severity of non-existent log message
On autogenerated FMAPs, there's no `UNIFIED_MRC_CACHE` region. The current code will print a spurious error message about it, though.
Reduce the log level to BIOS_INFO to avoid confusion.
Change-Id: I0961bb2a7d2d81dc5c0d28f6e6c29b320421fc3e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45076/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of non-existent log message ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45076/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45076/1//COMMIT_MSG@7 PS1, Line 7: drivers/mrc_cache: Reduce severity of an error message
Maybe: […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of non-existent log message ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of non-existent log message ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of non-existent log message ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45076/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45076/2//COMMIT_MSG@7 PS2, Line 7: non-existent I am so sorry, reading the summary again, is ambiguous and confusing.
non-existence might avoid the confusion.
Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Christian Walter, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45076
to look at the new patch set (#3).
Change subject: drivers/mrc_cache: Reduce severity of `region not found` log message ......................................................................
drivers/mrc_cache: Reduce severity of `region not found` log message
On autogenerated FMAPs, there's no `UNIFIED_MRC_CACHE` region. The current code will print a spurious error message about it, though.
Reduce the log level to BIOS_INFO to avoid confusion.
Change-Id: I0961bb2a7d2d81dc5c0d28f6e6c29b320421fc3e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45076/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of `region not found` log message ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45076/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45076/2//COMMIT_MSG@7 PS2, Line 7: non-existent
I am so sorry, reading the summary again, is ambiguous and confusing. […]
I went with `region not found` instead, paraphrasing the affected log message.
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45076 )
Change subject: drivers/mrc_cache: Reduce severity of `region not found` log message ......................................................................
drivers/mrc_cache: Reduce severity of `region not found` log message
On autogenerated FMAPs, there's no `UNIFIED_MRC_CACHE` region. The current code will print a spurious error message about it, though.
Reduce the log level to BIOS_INFO to avoid confusion.
Change-Id: I0961bb2a7d2d81dc5c0d28f6e6c29b320421fc3e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45076 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index 0e42120..00652ac 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -480,7 +480,7 @@ return 0;
if (lookup_region_by_name(name, ®ion) < 0) { - printk(BIOS_ERR, "MRC: Could not find region '%s'\n", name); + printk(BIOS_INFO, "MRC: Could not find region '%s'\n", name); return -1; }
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)