Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Maximilian Brune, Raul Rangel.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77885?usp=email )
Change subject: x86: Add ramstage CBFS cache support ......................................................................
Patch Set 28:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77885/comment/c8d03e2c_bd8bb44d : PS28, Line 7: cache cache scratchpad
https://review.coreboot.org/c/coreboot/+/77885/comment/79a6134d_ebf84b07 : PS28, Line 8: A sentence about the motivation would be great.
https://review.coreboot.org/c/coreboot/+/77885/comment/14f11ca1_493f3b7e : PS28, Line 17: Operating System I’d spell it lowercase. (Please fell free to ignore.)
https://review.coreboot.org/c/coreboot/+/77885/comment/257f1490_e8b58e5f : PS28, Line 29: offer offer*s*
https://review.coreboot.org/c/coreboot/+/77885/comment/57d16c53_7d220b7f : PS28, Line 35: defines define
Patchset:
PS28: Nice work.
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/77885/comment/f3027476_e4afe240 : PS28, Line 167: Allocate the CBFS cache buffer as a C static buffer (in the : .bss section). The existing descriptions are very terse,
https://review.coreboot.org/c/coreboot/+/77885/comment/5cbbc481_de64031b : PS28, Line 167: Allocate the CBFS cache buffer as a C static buffer (in the : .bss section). I know, the existing descriptions are very terse, but it’d be great if you could extend this little.
https://review.coreboot.org/c/coreboot/+/77885/comment/eb26bc24_04355d3f : PS28, Line 167: Allocate the CBFS cache buffer as a C static buffer (in the : .bss section). I know, the existing descriptions are very terse, but it’d be great if you could extend this little.