Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Rajasekhar Venkatanagapavan, Patrick Rudolph, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54676 )
Change subject: soc/intel/adl: Add SKU specific power limits support
......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54676/comment/458d6128_cc6940fc
PS6, Line 9: depends
depend
Ack
https://review.coreboot.org/c/coreboot/+/54676/comment/b4ef05a2_29112f44
PS6, Line 11: and
remove
Done
File src/soc/intel/alderlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/54676/comment/d3d97992_d4a7399a
PS6, Line 63: sa_pci_id = sa ? pci_read_config16(sa, PCI_DEVICE_ID) : 0xFFFF;
Move the assignments right before the switch statement?
Ack
https://review.coreboot.org/c/coreboot/+/54676/comment/2cccdc40_d82672ad
PS6, Line 78: */
You might want to use the concise style: […]
Ack
https://review.coreboot.org/c/coreboot/+/54676/comment/66406209_73c07e97
PS6, Line 94: "configuration\n", sa_pci_id);
Please put the string on one line.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54676
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1676e2b4d611cdc85e770f131d5b6d5ecd180be
Gerrit-Change-Number: 54676
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rajasekhar Venkatanagapavan
rajasekhar.venkatanagapavan@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rajasekhar Venkatanagapavan
rajasekhar.venkatanagapavan@intel.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sat, 29 May 2021 08:52:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment