Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48083 )
Change subject: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG@9
PS5, Line 9: Set mainboard_ops.init directly instead of using the indirection via a
: mainboard_enable function.
So there is a difference between struct device_operations and struct chip_operations. […]
Yeah, I was confused by the names.
I had a look at how google boards do it. Some use mainboard chip init, others mainboard dev init, so there shouldn't be a problem, since it's only PCRs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48083
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae
Gerrit-Change-Number: 48083
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Nov 2020 20:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment