Attention is currently required from: Tarun Tuli.
Hello build bot (Jenkins), Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74293
to look at the new patch set (#2).
Change subject: soc/intel/{adl, cmn}: Send CSE EOP Async CMD early ......................................................................
soc/intel/{adl, cmn}: Send CSE EOP Async CMD early
This patch sends the CSE EOP command asynchronous implementation early as part of `soc_init_pre_device`.
Without this patch the duration between asynchronous CSE EOP send and receive commands is not ample whichcauses idle delay while waiting for EOP response.
The goal of the CSE async implementation is to avoid idle delay while capturing the response from CSE EOP cmd.
This patch helps to create ample duration between CSE EOP command being sent and response being captured.
TEST=Able to boot google/marasov EVT sku to ChromeOS and observed ~30ms of boot time savings (across warm and cold reset scenarios).
Without this patch:
963:returning from FspMultiPhaseSiInit 907,326 (97,293) ... ... 115:finished elog init 967,343 (2,581) 942:before sending EOP to ME 967,821 (478) … 16:finished LZMA decompress (ignore for x86) 1,017,937 (12,135) 943:after sending EOP to ME 1,067,799 (49,861) … … 1101:jumping to kernel 1,144,587 (13,734)
Total Time: 1,144,549
With this patch: 963:returning from FspMultiPhaseSiInit 918,291 (97,320) 942:before sending EOP to ME 918,522 (230) ... ... 16:finished LZMA decompress (ignore for x86) 1,029,476 (12,483) 943:after sending EOP to ME 1,033,456 (3,980) ... ... 1101:jumping to kernel 1,111,410 (14,007)
Total Time: 1,111,375
Change-Id: Idaf45ef28747bebc02347f0faa77cc858a4a8ef1 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/alderlake/chip.c M src/soc/intel/common/block/cse/cse.c 2 files changed, 68 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/74293/2