Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27329 )
Change subject: timestamps: denote "end of romstage" right before loading ramstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27329/1/src/arch/x86/cbfs_and_run.c
File src/arch/x86/cbfs_and_run.c:
https://review.coreboot.org/#/c/27329/1/src/arch/x86/cbfs_and_run.c@22
PS1, Line 22: timestamp_add_now(TS_END_ROMSTAGE);
should this go into run_ramstage instead, right before the jump?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3524a757f5274815d62a17c58a18ed6b9aa726bf
Gerrit-Change-Number: 27329
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 15 Apr 2019 20:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment