Change in coreboot[master]: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ......................................................................
Patch Set 60:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... PS60, Line 18: Scope (_SB) { : Device (PCI0) {
Device (_SB. […]
You are always complaining about this - but this throws an error when comping the asl code ;)
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/memory.c:
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... PS60, Line 27: .rcomp_resistor = {121, 81, 100},
Are you sure? These values are for CFL-U […]
Where do you got those values from? - Also why CFL-U?
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... PS60, Line 30: .rcomp_targets = {100, 40, 20, 20, 26},
Same here, these look like CFL-U values. […]
Same question? Origin?
-
Christian Walter (Code Review)