Change in coreboot[master]: libpayload/i8042: Increase response timeout to 1.5s

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47588 )

Change subject: libpayload/i8042: Increase response timeout to 1.5s
......................................................................

libpayload/i8042: Increase response timeout to 1.5s

The current timeout of 500ms is too low. For instance self-test
of the KBC integrated into IT8516E took almost 1s in tests. We
already check for presence of the KBC before the self-test. So
the timeout should only trigger on a hardware defect and we can
leave some margin.

Change-Id: I95f01a4e605a9c7deb894a71e102c3a881759bb1
Signed-off-by: Nico Huber 
---
M payloads/libpayload/drivers/i8042/i8042.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/47588/1

diff --git a/payloads/libpayload/drivers/i8042/i8042.c b/payloads/libpayload/drivers/i8042/i8042.c
index 50d013d..84bad55 100644
--- a/payloads/libpayload/drivers/i8042/i8042.c
+++ b/payloads/libpayload/drivers/i8042/i8042.c
@@ -159,7 +159,7 @@
  */
 static u8 i8042_wait_data_rdy(void)
 {
-	int retries = 10000;
+	int retries = 30000;
    while (retries-- && !(read_status() & OBF))
    	udelay(50);

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47588 )

Change subject: libpayload/i8042: Increase response timeout to 1.5s
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47588 )

Change subject: libpayload/i8042: Increase response timeout to 1.5s
......................................................................

libpayload/i8042: Increase response timeout to 1.5s

The current timeout of 500ms is too low. For instance self-test
of the KBC integrated into IT8516E took almost 1s in tests. We
already check for presence of the KBC before the self-test. So
the timeout should only trigger on a hardware defect and we can
leave some margin.

Change-Id: I95f01a4e605a9c7deb894a71e102c3a881759bb1
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47588
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M payloads/libpayload/drivers/i8042/i8042.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/payloads/libpayload/drivers/i8042/i8042.c b/payloads/libpayload/drivers/i8042/i8042.c
index 50d013d..84bad55 100644
--- a/payloads/libpayload/drivers/i8042/i8042.c
+++ b/payloads/libpayload/drivers/i8042/i8042.c
@@ -159,7 +159,7 @@
  */
 static u8 i8042_wait_data_rdy(void)
 {
-	int retries = 10000;
+	int retries = 30000;
    while (retries-- && !(read_status() & OBF))
    	udelay(50);