Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41607 )
Change subject: drivers/intel/mipi_camera: Generate SSDT for camera ......................................................................
Patch Set 16:
(11 comments)
https://review.coreboot.org/c/coreboot/+/41607/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41607/12//COMMIT_MSG@7 PS12, Line 7: drivers/intel/mipi_camera: camera SSDT generation
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12//COMMIT_MSG@12 PS12, Line 12: missing some properties needed for Linux drivers.
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12//COMMIT_MSG@9 PS12, Line 9: Some boards & variants are using raw asl files to define the ACPI devices : (and related properties) required by Linux MIPI camera drivers. : The mipi_camera driver can provide a SSDB property, but it's : missing some properties needed for Linux drivers.
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12//COMMIT_MSG@21 PS12, Line 21: asl
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12//COMMIT_MSG@22 PS12, Line 22:
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... PS12, Line 42: uint32_t i, j;
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... PS12, Line 607: prefix = "ERR"; /* Error */
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... PS12, Line 612: know
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... PS12, Line 131: * General settings that can be used for any type (but doesn't
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... PS12, Line 132: * necessarily need to be used/specified for each device.
I will update this in next patch.
Done
https://review.coreboot.org/c/coreboot/+/41607/12/src/drivers/intel/mipi_cam... PS12, Line 163: * you can use zero for a value.
I will update this in next patch.
Done
-
Sugnan Prabhu S (Code Review)