Change in coreboot[master]: soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48485 )
Change subject: soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used ......................................................................
soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used
FCH_AOAC_UART_FOR_CONSOLE will only be used in the code if PICASSO_CONSOLE_UART is selected, so only check if it's a valid value in this case.
Change-Id: I103dd8d469a084c7dc7dcf55175b1f77f900adc5 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/aoac.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/48485/1
diff --git a/src/soc/amd/picasso/aoac.c b/src/soc/amd/picasso/aoac.c index 7fd839b..c97700d 100644 --- a/src/soc/amd/picasso/aoac.c +++ b/src/soc/amd/picasso/aoac.c @@ -12,7 +12,7 @@ : CONFIG_UART_FOR_CONSOLE == 2 ? FCH_AOAC_DEV_UART2 \ : CONFIG_UART_FOR_CONSOLE == 3 ? FCH_AOAC_DEV_UART3 \ : -1) -#if FCH_AOAC_UART_FOR_CONSOLE == -1 +#if CONFIG(PICASSO_CONSOLE_UART) && FCH_AOAC_UART_FOR_CONSOLE == -1 # error Unsupported UART_FOR_CONSOLE chosen #endif
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48485 )
Change subject: soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c File src/soc/amd/picasso/aoac.c:
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c@... PS4, Line 43: aoac_devs Some day we should make this smarter. We can probably save a little power by not enabling devices a board doesn't use.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48485 )
Change subject: soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c File src/soc/amd/picasso/aoac.c:
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c@... PS4, Line 43: aoac_devs
Some day we should make this smarter. […]
I agree, but that's not something i'll have time to look into this year
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48485 )
Change subject: soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c File src/soc/amd/picasso/aoac.c:
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c@... PS4, Line 43: aoac_devs
I agree, but that's not something i'll have time to look into this year
It's on the list
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48485 )
Change subject: soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used ......................................................................
soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used
FCH_AOAC_UART_FOR_CONSOLE will only be used in the code if PICASSO_CONSOLE_UART is selected, so only check if it's a valid value in this case.
Change-Id: I103dd8d469a084c7dc7dcf55175b1f77f900adc5 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48485 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/aoac.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/aoac.c b/src/soc/amd/picasso/aoac.c index 7fd839b..c97700d 100644 --- a/src/soc/amd/picasso/aoac.c +++ b/src/soc/amd/picasso/aoac.c @@ -12,7 +12,7 @@ : CONFIG_UART_FOR_CONSOLE == 2 ? FCH_AOAC_DEV_UART2 \ : CONFIG_UART_FOR_CONSOLE == 3 ? FCH_AOAC_DEV_UART3 \ : -1) -#if FCH_AOAC_UART_FOR_CONSOLE == -1 +#if CONFIG(PICASSO_CONSOLE_UART) && FCH_AOAC_UART_FOR_CONSOLE == -1 # error Unsupported UART_FOR_CONSOLE chosen #endif
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)