Change in coreboot[master]: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011
Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011
voxel change amp to ALC1011 adding ALC1011 amp acpi info into devicetree
BUG=b:160550394 BRANCH=None TEST=build and verify ALC1011 can be recognized.
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: If3e7b829000a61a27f6a45a2688bb434e57f479a --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/voxel/overridetree.cb 3 files changed, 15 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43549/1
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 06bbc58..a3ece12 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -37,6 +37,8 @@ bool "-> Voxel" select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU + select CHROMEOS_DSM_CALIB + select DRIVERS_I2C_RT1011
config BOARD_GOOGLE_DELBIN bool "-> Delbin" diff --git a/src/mainboard/google/volteer/fw_config.c b/src/mainboard/google/volteer/fw_config.c index 61e20f4..6cbde24 100644 --- a/src/mainboard/google/volteer/fw_config.c +++ b/src/mainboard/google/volteer/fw_config.c @@ -72,7 +72,8 @@ gpio_configure_pads(i2s_disable_pads, ARRAY_SIZE(i2s_disable_pads)); } if (fw_config_probe(FW_CONFIG(AUDIO, MAX98357_ALC5682I_I2S)) || - fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682I_I2S))) { + fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682I_I2S)) || + fw_config_probe(FW_CONFIG(AUDIO, RT1011_ALC5682I_I2S))) { printk(BIOS_INFO, "Configure GPIOs for I2S audio.\n"); gpio_configure_pads(i2s_enable_pads, ARRAY_SIZE(i2s_enable_pads)); gpio_configure_pads(dmic_enable_pads, ARRAY_SIZE(dmic_enable_pads)); diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index 2219de0..8838705 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -12,24 +12,23 @@ register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" device i2c 1a on + probe AUDIO RT1011_ALC5682I_I2S end end - chip drivers/i2c/max98373 - register "vmon_slot_no" = "0" - register "imon_slot_no" = "1" + chip drivers/i2c/rt1011 + register "desc" = ""RT1011 Woofer Left Speaker Amp"" register "uid" = "0" - register "desc" = ""Right Speaker Amp"" - register "name" = ""MAXR"" - device i2c 31 on + register "name" = ""RTWL"" + device i2c 38 on + probe AUDIO RT1011_ALC5682I_I2S end end - chip drivers/i2c/max98373 - register "vmon_slot_no" = "2" - register "imon_slot_no" = "3" + chip drivers/i2c/rt1011 + register "desc" = ""RT1011 Woofer Right Speaker Amp"" register "uid" = "1" - register "desc" = ""Left Speaker Amp"" - register "name" = ""MAXL"" - device i2c 32 on + register "name" = ""RTWR"" + device i2c 39 on + probe AUDIO RT1011_ALC5682I_I2S end end end # I2C #0 0xA0E8
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 1:
Please fix the build error:
In file included from src/mainboard/google/volteer/fw_config.c:5: src/mainboard/google/volteer/fw_config.c: In function 'fw_config_handle': src/include/fw_config.h:28:17: error: 'FW_CONFIG_FIELD_AUDIO_OPTION_RT1011_ALC5682I_I2S_NAME' undeclared (first use in this function); did you mean 'FW_CONFIG_FIELD_AUDIO_OPTION_MAX98357_ALC5682I_I2S_NAME'? .option_name = FW_CONFIG_FIELD_##__field##_OPTION_##__option##_NAME, \ ^~~~~~~~~~~~~~~~ src/mainboard/google/volteer/fw_config.c:76:22: note: in expansion of macro 'FW_CONFIG' fw_config_probe(FW_CONFIG(AUDIO, RT1011_ALC5682I_I2S))) { ^~~~~~~~~ src/include/fw_config.h:28:17: note: each undeclared identifier is reported only once for each function it appears in .option_name = FW_CONFIG_FIELD_##__field##_OPTION_##__option##_NAME, \ ^~~~~~~~~~~~~~~~ src/mainboard/google/volteer/fw_config.c:76:22: note: in expansion of macro 'FW_CONFIG' fw_config_probe(FW_CONFIG(AUDIO, RT1011_ALC5682I_I2S))) { ^~~~~~~~~ src/include/fw_config.h:30:11: error: 'FW_CONFIG_FIELD_AUDIO_OPTION_RT1011_ALC5682I_I2S_VALUE' undeclared (first use in this function); did you mean 'FW_CONFIG_FIELD_AUDIO_OPTION_MAX98357_ALC5682I_I2S_VALUE'? .value = FW_CONFIG_FIELD_##__field##_OPTION_##__option##_VALUE \ ^~~~~~~~~~~~~~~~ src/mainboard/google/volteer/fw_config.c:76:22: note: in expansion of macro 'FW_CONFIG' fw_config_probe(FW_CONFIG(AUDIO, RT1011_ALC5682I_I2S))) { ^~~~~~~~~ src/mainboard/google/volteer/fw_config.c: At top level: cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors make[1]: *** [Makefile:362: /cb-build/coreboot-gerrit.0/default/GOOGLE_TERRADOR/ramstage/mainboard/google/volteer/fw_config.o] Error 1 make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit'
Hello build bot (Jenkins), David Wu, Mac Chiang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43549
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011
voxel change amp to ALC1011 adding ALC1011 amp acpi info into devicetree
BUG=b:160550394 BRANCH=None TEST=build and verify ALC1011 can be recognized.
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: If3e7b829000a61a27f6a45a2688bb434e57f479a --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/voxel/overridetree.cb 4 files changed, 16 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43549/2
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 16: option RT1011_ALC5682I_I2S 4 Caveh, is it okay to assign 4 to this codec/amplifier? If so, we need to add the program setting.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43549/2//COMMIT_MSG Commit Message:
PS2: please use a conventional commit message style.
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 16: option RT1011_ALC5682I_I2S 4
Caveh, is it okay to assign 4 to this codec/amplifier? If so, we need to add the program setting.
yes, let's update the program.star first 😊 and add the Cq-Depend.
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 18: chip drivers/i2c/rt1011 can you share the latest schematics? the most recent i could find still shows the max98373.
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 19: Woofer do you want to keep "Woofer" here or is it just a speaker?
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee... PS2, Line 21: RTWL rename this if you decide to drop "woofer" from the description.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43549/2//COMMIT_MSG Commit Message:
PS2:
please use a conventional commit message style.
sorry, never mind - the line wrapping on the first few lines distracted me.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43549/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43549/2//COMMIT_MSG@9 PS2, Line 9: voxel change amp to ALC1011 : adding ALC1011 amp acpi info into devicetree Maybe:
For voxel the AMP changed to ALC1011, so add the ACPI info to the devicetree.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 2:
Is this CL still needed?
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 2:
Patch Set 2:
Is this CL still needed?
Abandon this CL since we don't need this.
Sheng-Liang Pan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011 ......................................................................
Abandoned
-
Caveh Jalali (Code Review) -
Nick Vaccaro (Code Review)
-
Paul Menzel (Code Review)
-
Sheng-Liang Pan (Code Review)
-
Zhuohao Lee (Code Review)