View Change

5 comments:

• Commit Message:

  • Patch Set #2:

    please use a conventional commit message style.

• File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

  • Patch Set #2, Line 16: option RT1011_ALC5682I_I2S 4

    Caveh, is it okay to assign 4 to this codec/amplifier? If so, we need to add the program setting.

    yes, let's update the program.star first 😊
    and add the Cq-Depend.

• File src/mainboard/google/volteer/variants/voxel/overridetree.cb:

  • Patch Set #2, Line 18: chip drivers/i2c/rt1011

    can you share the latest schematics? the most recent i could find still
    shows the max98373.

  • Patch Set #2, Line 19: Woofer

    do you want to keep "Woofer" here or is it just a speaker?

  • Patch Set #2, Line 21: RTWL

    rename this if you decide to drop "woofer" from the description.

To view, visit change 43549. To unsubscribe, or for help writing mail filters, visit settings.