Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48506 )
Change subject: soc/amd/picasso: use all-y for aoac target ......................................................................
soc/amd/picasso: use all-y for aoac target
Since aoac gets also linked into verstage on PSP, all-y can be used here.
Change-Id: I74607123ebc8115aa7efbb9a364d9632372b52cb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/Makefile.inc 1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/48506/1
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 6e1d88b..7cbae92 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -10,9 +10,9 @@ subdirs-$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK) += psp_verstage
all-y += config.c +all-y += aoac.c
bootblock-y += bootblock.c -bootblock-y += aoac.c bootblock-y += early_fch.c bootblock-y += i2c.c bootblock-y += uart.c @@ -27,12 +27,10 @@ romstage-y += memmap.c romstage-y += uart.c romstage-$(CONFIG_PICASSO_CONSOLE_UART) += uart_console.c -romstage-y += aoac.c romstage-y += psp.c romstage-y += mrc_cache.c
verstage-y += i2c.c -verstage-y += aoac.c verstage_x86-y += gpio.c verstage_x86-y += uart.c verstage_x86-$(CONFIG_PICASSO_CONSOLE_UART) += uart_console.c @@ -47,7 +45,6 @@ ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += agesa_acpi.c ramstage-y += gpio.c -ramstage-y += aoac.c ramstage-y += fch.c ramstage-y += reset.c ramstage-y += acp.c
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48506 )
Change subject: soc/amd/picasso: use all-y for aoac target ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48506/3/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48506/3/src/soc/amd/picasso/Makefil... PS3, Line 11: At some point, let's eventually consider a comment here to caution against using all-y for files not used for PSP verstage. Feel free to just ack (wanted to ensure you saw the comment) and we'll add it to the list.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48506 )
Change subject: soc/amd/picasso: use all-y for aoac target ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48506/3/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48506/3/src/soc/amd/picasso/Makefil... PS3, Line 11:
At some point, let's eventually consider a comment here to caution against using all-y for files not […]
added that in a follow-up patch: CB:48521
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48506 )
Change subject: soc/amd/picasso: use all-y for aoac target ......................................................................
Patch Set 4: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48506 )
Change subject: soc/amd/picasso: use all-y for aoac target ......................................................................
soc/amd/picasso: use all-y for aoac target
Since aoac gets also linked into verstage on PSP, all-y can be used here.
Change-Id: I74607123ebc8115aa7efbb9a364d9632372b52cb Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48506 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/Makefile.inc 1 file changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 6e1d88b..7cbae92 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -10,9 +10,9 @@ subdirs-$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK) += psp_verstage
all-y += config.c +all-y += aoac.c
bootblock-y += bootblock.c -bootblock-y += aoac.c bootblock-y += early_fch.c bootblock-y += i2c.c bootblock-y += uart.c @@ -27,12 +27,10 @@ romstage-y += memmap.c romstage-y += uart.c romstage-$(CONFIG_PICASSO_CONSOLE_UART) += uart_console.c -romstage-y += aoac.c romstage-y += psp.c romstage-y += mrc_cache.c
verstage-y += i2c.c -verstage-y += aoac.c verstage_x86-y += gpio.c verstage_x86-y += uart.c verstage_x86-$(CONFIG_PICASSO_CONSOLE_UART) += uart_console.c @@ -47,7 +45,6 @@ ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += agesa_acpi.c ramstage-y += gpio.c -ramstage-y += aoac.c ramstage-y += fch.c ramstage-y += reset.c ramstage-y += acp.c
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)