Change in coreboot[master]: soc/amd/piasso,cezanne: add warning about using all-y in Makefile.inc
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48521 )
Change subject: soc/amd/piasso,cezanne: add warning about using all-y in Makefile.inc ......................................................................
soc/amd/piasso,cezanne: add warning about using all-y in Makefile.inc
all-y will also add a compilation unit to the verstage on PSP build that runs on an ARM code instead of a x86 one. At the moment Cezanne doesn't have verstage on PSP support yet, but since it'll eventually land it doesn't hurt to already add the comment now.
Change-Id: I15fb66e796cab48737ba5ac463c4c973794a005a Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/picasso/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/48521/1
diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.inc index 946e480..e7d0aea 100644 --- a/src/soc/amd/cezanne/Makefile.inc +++ b/src/soc/amd/cezanne/Makefile.inc @@ -2,6 +2,7 @@
ifeq ($(CONFIG_SOC_AMD_CEZANNE),y)
+# Beware that all-y also adds the compilation unit to verstage on PSP all-y += config.c
bootblock-y += bootblock.c diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 7cbae92..142fb0c 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -9,6 +9,7 @@ subdirs-y += ../../../cpu/x86/smm subdirs-$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK) += psp_verstage
+# Beware that all-y also adds the compilation unit to verstage on PSP all-y += config.c all-y += aoac.c
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48521 )
Change subject: soc/amd/piasso,cezanne: add warning about using all-y in Makefile.inc ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48521 )
Change subject: soc/amd/piasso,cezanne: add warning about using all-y in Makefile.inc ......................................................................
soc/amd/piasso,cezanne: add warning about using all-y in Makefile.inc
all-y will also add a compilation unit to the verstage on PSP build that runs on an ARM code instead of a x86 one. At the moment Cezanne doesn't have verstage on PSP support yet, but since it'll eventually land it doesn't hurt to already add the comment now.
Change-Id: I15fb66e796cab48737ba5ac463c4c973794a005a Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48521 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/picasso/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.inc index 946e480..e7d0aea 100644 --- a/src/soc/amd/cezanne/Makefile.inc +++ b/src/soc/amd/cezanne/Makefile.inc @@ -2,6 +2,7 @@
ifeq ($(CONFIG_SOC_AMD_CEZANNE),y)
+# Beware that all-y also adds the compilation unit to verstage on PSP all-y += config.c
bootblock-y += bootblock.c diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 7cbae92..142fb0c 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -9,6 +9,7 @@ subdirs-y += ../../../cpu/x86/smm subdirs-$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK) += psp_verstage
+# Beware that all-y also adds the compilation unit to verstage on PSP all-y += config.c all-y += aoac.c
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)