Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun, Utkarsh H Patel.
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78163?usp=email )
Change subject: soc/intel/meteorlake: Update TBT PCIe Reg Map offsets for QS
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
which doc should follow to reflect this change ? […]
This change is not part of any doc, but I will let you if could get some reference.
Yes this is to do with new revisions coming in with Prod SOC.
File src/soc/intel/meteorlake/acpi/tcss_pcierp.asl:
https://review.coreboot.org/c/coreboot/+/78163/comment/92b8d4b8_20aced3c :
PS6, Line 3: 0xC00
shouldn't you make this value also configurable based on Config selection ? i.e. […]
0xC00 is size increase to access higher offsets so IMO no need to wrap under config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78163?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0497f7108ef5046c2694aece232263582514a0c5
Gerrit-Change-Number: 78163
Gerrit-PatchSet: 6
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 05 Oct 2023 19:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment