Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42496 )
Change subject: lib: Add ASan support to ramstage on x86 arch
......................................................................
Patch Set 19:
Patch Set 18: Code-Review+1
I rebased the series on master to be able to build it on ppc64le, rebuilt crossgcc, built an image for the ASRock E350M1 with KASAN enable, and it booted without errors. (I would have expected problems with AGESA, but maybe Coverity and the other static analyzers found all the bug already.)
Great job!
It’d be great if you rebased your series on origin/master.
Thanks for testing it on your hardware.
I've rebased it now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica06bd2be78fcfc79fa888721ed920d4e8248f3b
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 19
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 10 Jul 2020 22:21:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment