Change in coreboot[master]: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: lib:...

Raul Rangel (Code Review)

9 Jul 2020 9 Jul '20

8:26 p.m.

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43329 )

Change subject: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE ......................................................................

include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE

ACPI names can only be 4 characters long. Define a constant that defines the size of the name + the NULL terminator.

BUG=b:154756391 TEST=none

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Iad230c029f324005620ddad66c433ada26be78cc --- M src/include/acpi/acpi.h 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43329/1

diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index cd99899..dabbb2b 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -52,6 +52,8 @@ #define RSDP_SIG "RSD PTR " /* RSDT pointer signature */ #define ASLC "CORE" /* Must be exactly 4 bytes long! */

+#define ACPI_NAME_BUFFER_SIZE 5 /* 4 chars + 1 NULL */ + /* * The assigned ACPI ID for the coreboot project is 'BOOT' * http://www.uefi.org/acpi_id_list

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

9 Jul 9 Jul

8:29 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43329 )

Change subject: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad230c029f324005620ddad66c433ada26be78cc Gerrit-Change-Number: 43329 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Thu, 09 Jul 2020 18:29:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

11:37 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43329 )

Change subject: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43329/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43329/1//COMMIT_MSG@10 PS1, Line 10: L remove one of these 'L's

https://review.coreboot.org/c/coreboot/+/43329/1/src/include/acpi/acpi.h File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/43329/1/src/include/acpi/acpi.h@55 PS1, Line 55: L same as commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad230c029f324005620ddad66c433ada26be78cc Gerrit-Change-Number: 43329 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Jul 2020 21:37:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Raul Rangel (Code Review)

10 Jul 10 Jul

12:19 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43329

to look at the new patch set (#2).

Change subject: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE ......................................................................

include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE

ACPI names can only be 4 characters long. Define a constant that defines the size of the name + the NUL terminator.

BUG=b:154756391 TEST=none

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Iad230c029f324005620ddad66c433ada26be78cc --- M src/include/acpi/acpi.h 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43329/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad230c029f324005620ddad66c433ada26be78cc Gerrit-Change-Number: 43329 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Raul Rangel (Code Review)

12:20 a.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43329 )

Change subject: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43329/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43329/1//COMMIT_MSG@10 PS1, Line 10: L

...

remove one of these 'L's

Done

https://review.coreboot.org/c/coreboot/+/43329/1/src/include/acpi/acpi.h File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/43329/1/src/include/acpi/acpi.h@55 PS1, Line 55: L

...

same as commit message.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad230c029f324005620ddad66c433ada26be78cc Gerrit-Change-Number: 43329 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Jul 2020 22:20:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Aaron Durbin (Code Review)

12:25 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43329 )

Change subject: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad230c029f324005620ddad66c433ada26be78cc Gerrit-Change-Number: 43329 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Jul 2020 22:25:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

11 Jul 11 Jul

12:50 a.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43329 )

Change subject: include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE ......................................................................

include/acpi/acpi.h: Add ACPI_NAME_BUFFER_SIZE

ACPI names can only be 4 characters long. Define a constant that defines the size of the name + the NUL terminator.

BUG=b:154756391 TEST=none

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Iad230c029f324005620ddad66c433ada26be78cc Reviewed-on: https://review.coreboot.org/c/coreboot/+/43329 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/acpi/acpi.h 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index cd99899..35a1dc3 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -52,6 +52,8 @@ #define RSDP_SIG "RSD PTR " /* RSDT pointer signature */ #define ASLC "CORE" /* Must be exactly 4 bytes long! */

+#define ACPI_NAME_BUFFER_SIZE 5 /* 4 chars + 1 NUL */ + /* * The assigned ACPI ID for the coreboot project is 'BOOT' * http://www.uefi.org/acpi_id_list

-- To view, visit https://review.coreboot.org/c/coreboot/+/43329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad230c029f324005620ddad66c433ada26be78cc Gerrit-Change-Number: 43329 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1393

days inactive

1394

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Aaron Durbin (Code Review)
Felix Held (Code Review)
Furquan Shaikh (Code Review)
Raul Rangel (Code Review)