Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42794 )
Change subject: crossgcc: Allow GCC to get asan shadow offset at runtime ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42794/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42794/11//COMMIT_MSG@15 PS11, Line 15:
Please add more details, why GCC needs to be patched for coreboot, but apparently not for the Linux […]
I've added the details in the commit message.
Yes it is required in newer GCC versions as well. However, I'll try to convince them to include this change in later versions by initiating a conversation on GCC mailing list.
https://review.coreboot.org/c/coreboot/+/42794/11/util/crossgcc/patches/gcc-... File util/crossgcc/patches/gcc-8.3.0_asan_shadow_offset_callback.patch:
https://review.coreboot.org/c/coreboot/+/42794/11/util/crossgcc/patches/gcc-... PS11, Line 1: diff -urN gcc-8.3.0.orig/gcc/asan.c gcc-8.3.0/gcc/asan.c
Please add a patch file created with `git format-patch -1`, which contains a commit message.
Now I've created a patch file using git format-patch command. Let me know if it requires any further changes.