Martin Roth has posted comments on this change. ( https://review.coreboot.org/27876 )
Change subject: soc/amd/stoneyridge: Set undocumented misc register ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/27876/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27876/1//COMMIT_MSG@7 PS1, Line 7: Set undocumented misc register Maybe change this to what it does? This description is just ASKING for trouble.
soc/amd/stoneyridge: Prevent reboot in romstage
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 609: | You don't really need to or the bit in either here or below, do you?
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 614: uint32_t reg = misc_read32(0x50); This might be the spot to mention that it's an undocumented register.
https://review.coreboot.org/#/c/27876/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 615: (1 << 16) use BIT(16) from types.h?
-
Martin Roth (Code Review)