Change in coreboot[master]: mb/google/brya/var/vell: update gpio override - coreboot-gerrit

14 Dec 2021


      Attention is currently required from: Kevin Chiu, Paul Menzel, Robert Chen, Nick Vaccaro, Wisley Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override
......................................................................
Patch Set 26: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/vell/gpio.c:
https://review.coreboot.org/c/coreboot/+/59305/comment/f5070872_c7396d58 
PS26, Line 133: /*Add virtual GPIO*/
nit:
`/* Add virtual GPIOs for CPU PCIe RP */
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59305
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0
Gerrit-Change-Number: 59305
Gerrit-PatchSet: 26
Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Attention: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 14 Dec 2021 20:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment