Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 46:
(40 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/5dff7dbf_ca6a0ded PS46, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/3c881f40_94012ea5 PS46, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/06bb37b6_8530506c PS46, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/ee9ec31e_bda1b264 PS46, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/1401ee33_793b915d PS46, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/7ca7c92a_1e3f8480 PS46, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/2e7db708_d5ec41bc PS46, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/c519ffc0_b8fba695 PS46, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/d80a1d13_cdde673e PS46, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/4c82f35d_d7a412b9 PS46, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/23dff81d_1cc4f056 PS46, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/37f21667_3cfa6f84 PS46, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/a8d5b7d3_072fda62 PS46, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/283cca72_c496cc6d PS46, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/1d451674_4e0b8976 PS46, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/6803d239_1f8fbc19 PS46, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/494d8bf4_1e265a0e PS46, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/a5615158_4874497b PS46, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/06c37b84_051b9b40 PS46, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/490efd38_4f67f67c PS46, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/407ac645_80368524 PS46, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/0f9008dc_1c8356b5 PS46, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/51e6db1b_d9bf6a68 PS46, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/7bc163fe_0f2b2f68 PS46, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/ff6755fd_2838466a PS46, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/da407585_806381d3 PS46, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/32c527b1_de61ef4a PS46, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/6f4784b9_e6456e6f PS46, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/5a127ab3_95e6e834 PS46, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/ead3a80e_6dbcfe1c PS46, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/ea1b00df_b2e63869 PS46, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/2917345c_537031d3 PS46, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/5d786732_d51e25c5 PS46, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/398d14d8_23591250 PS46, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/1331e7a0_37818a6b PS46, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/5ec96ad0_367704a6 PS46, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/a003ba94_91800421 PS46, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/496aaf9f_3cafdd08 PS46, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/7d4c5a68_138ea67d PS46, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121763): https://review.coreboot.org/c/coreboot/+/49768/comment/f0020c0a_21284b2e PS46, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)