build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29104 )
Change subject: sdm845: Port I2C driver ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c File src/soc/qualcomm/sdm845/i2c.c:
https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c@279 PS3, Line 279: void i2c_init(unsigned qup_i2c_instance) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/i2c.c@440 PS3, Line 440: int platform_i2c_transfer(unsigned bus, struct i2c_msg *segments, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/... File src/soc/qualcomm/sdm845/include/soc/i2c.h:
https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/... PS3, Line 31: unsigned initialized; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/29104/3/src/soc/qualcomm/sdm845/include/soc/... PS3, Line 38: void i2c_init(unsigned qup_i2c_instance); Prefer 'unsigned int' to bare use of 'unsigned'