Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55205 )
Change subject: mb/intel/adlrvp: Use device aliases ......................................................................
Patch Set 3:
(6 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/4f1efbc1_b73e106d PS2, Line 320: device pci 10.0 off end : device pci 10.1 off end : device pci 10.6 off end # THC0 : device pci 10.7 off end # THC1
Below devices are THC0 and 1 for ADL-P […]
Hmmm, I see. It's somewhat annoying (why couldn't ADL-P and ADL-S use the same PCI B:D.F for these devices?) but we'll have to live with it. Maybe we will end up using two separate chipset devicetrees for ADL-P and ADL-S.
https://review.coreboot.org/c/coreboot/+/55205/comment/4b9f1961_00cccfd3 PS2, Line 324: device pci 11.0 off end : device pci 11.1 off end : device pci 11.2 off end : device pci 11.3 off end : device pci 11.4 off end : device pci 11.5 off end
same these devices belongs to ADL-S
Alright, I see. I'd appreciate if you could remove ADL-S devices in a separate commit.
https://review.coreboot.org/c/coreboot/+/55205/comment/b247ee02_7a786431 PS2, Line 331: device pci 12.5 off end
I don't see this device, mostly some mistake, better to remove this device from list
I'd remove it in the same commit that removes the ADL-S devices (see comment above), and mention why in that commit's message.
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/c073d70f_853abd66 PS3, Line 372: # W/A to FSP issue Does this comment still apply?
File src/mainboard/intel/adlrvp/devicetree_m.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/c6a09818_89740b8a PS3, Line 202: device ref pch_espi on end Already on in chipset.cb
https://review.coreboot.org/c/coreboot/+/55205/comment/38cbd357_ff97b73e PS3, Line 216: device ref fast_spi on end Already on in chipset.cb
-
Angel Pons (Code Review)