Attention is currently required from: Paul Menzel, Maximilian Brune, Angel Pons, Krystian Hebel.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69870 )
Change subject: intel/cmn/smm: Introduce PERIODIC_SMI_RATE_SELECTION_IN_GEN_PMCON_B
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/smm/Kconfig:
https://review.coreboot.org/c/coreboot/+/69870/comment/f2505adb_4f71230f
PS4, Line 53: Intel Core processors select the periodic SMI rate via GEN_PMCON_A.
It would probably result in much more code, since you have to implement it for every SOC.
Maybe if the discrepancy was much higher, but for now only the apollolake has been identified with such difference.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69870
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11241836ecc9066d323977b030686567c87ed256
Gerrit-Change-Number: 69870
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 13:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment