Change in coreboot[master]: util/inteltool: introduce common code lib

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39732 )

Change subject: util/inteltool: introduce common code lib
......................................................................

Patch Set 3:

(4 comments)

This change is ready for review.

https://review.coreboot.org/c/coreboot/+/39732/2/util/inteltool/common.c 
File util/inteltool/common.c:

https://review.coreboot.org/c/coreboot/+/39732/2/util/inteltool/common.c@14 
PS2, Line 14:
> What's with the short lines and these spaces instead of tabs to indent??

Done

https://review.coreboot.org/c/coreboot/+/39732/2/util/inteltool/common.c@39 
PS2, Line 39: uint64_t pci_mmio_base(struct pci_dev *dev)
> Move it next to the non-static things?

Done

https://review.coreboot.org/c/coreboot/+/39732/2/util/inteltool/common.c@57 
PS2, Line 57: if (!dev) {
            : 		printf("device not found.\n");
            : 		return;
            : 	}
> It's a static function, you control what you are passing to it...

Done

https://review.coreboot.org/c/coreboot/+/39732/2/util/inteltool/common.c@90 
PS2, Line 90: if (!mmio) {
            : 		printf("mmio error.\n");
            : 		return;
            : 	}
> It's a static function, you control what you are passing to it...

Done