Change in em100[master]: em100: Return exit status 1 when verify fails

[Ryan O'Leary (Code Review)]

Ryan O'Leary has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/44877 )

Change subject: em100: Return exit status 1 when verify fails
......................................................................

em100: Return exit status 1 when verify fails

Change-Id: I6fb21c0f6070eab5a700e4675b2e6da2f2f97930
Signed-off-by: Ryan O'Leary 
---
M em100.c
1 file changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/77/44877/1

diff --git a/em100.c b/em100.c
index e4f5e44..49d0d1e 100644
--- a/em100.c
+++ b/em100.c
@@ -1159,8 +1159,13 @@
    		done = read_sdram(&em100, readback, spi_start_address, length);
    		if (done && (memcmp(data, readback, length) == 0))
    			printf("Verify: PASS\n");
-			else
+			else {
    			printf("Verify: FAIL\n");
+				free(readback);
+				free(data);
+				em100_detach(&em100);
+				return 1;
+			}
    		free(readback);
    	}

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/44877 )

Change subject: em100: Return exit status 1 when verify fails
......................................................................

Patch Set 1: Code-Review+2

[Ryan O'Leary (Code Review)]

Ryan O'Leary has submitted this change. ( https://review.coreboot.org/c/em100/+/44877 )

Change subject: em100: Return exit status 1 when verify fails
......................................................................

em100: Return exit status 1 when verify fails

Change-Id: I6fb21c0f6070eab5a700e4675b2e6da2f2f97930
Signed-off-by: Ryan O'Leary 
Reviewed-on: https://review.coreboot.org/c/em100/+/44877
Tested-by: build bot (Jenkins) 
Reviewed-by: Stefan Reinauer 
---
M em100.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, approved

diff --git a/em100.c b/em100.c
index e4f5e44..49d0d1e 100644
--- a/em100.c
+++ b/em100.c
@@ -1159,8 +1159,13 @@
    		done = read_sdram(&em100, readback, spi_start_address, length);
    		if (done && (memcmp(data, readback, length) == 0))
    			printf("Verify: PASS\n");
-			else
+			else {
    			printf("Verify: FAIL\n");
+				free(readback);
+				free(data);
+				em100_detach(&em100);
+				return 1;
+			}
    		free(readback);
    	}