[S] Change in coreboot[master]: soc/intel/alderlake: Hook up the OC watchdog

[Michał Żygowski (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Michał Kopeć, Angel Pons, Werner Zeh.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68945 )

Change subject: soc/intel/alderlake: Hook up the OC watchdog
......................................................................

Patch Set 16:

(1 comment)

File src/soc/intel/alderlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/68945/comment/7820d39e_e1ce8b74 
PS16, Line 169: CONFIG_SOC_INTEL_COMMON_OC_WDT_TIMEOUT_SECONDS
> wondering if WDT timeout value would be different between ADL/RPL and MTL SoCs? If not then you could use static value.

And why it should be static? One of the watchdog features is to set the watchdog timeout, why should we disallow users to do that?
> So why do you need CB:72072 ?

Because of the periodic SMI implementation to reload the watchdog. I have extended the SMM common block which is also used by APL, unfortunately. So in order to not break anything when periodic SMI is selected in Kconfig, I had to add missing definitions. APL is not selecting the OC WDT nor will be using it.