Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52952 )
Change subject: soc/amd/common/espi: Print set eSPI peripheral config ......................................................................
soc/amd/common/espi: Print set eSPI peripheral config
This will print the config we are setting on the eSPI peripheral.
i.e., Setting general configuration: slave: 0x98a00000 controller: 0xe2000000 eSPI Slave configuration: CRC checking enabled Dedicated Alert# used to signal alert event eSPI quad IO mode selected Only eSPI single IO mode supported Alert# pin is open-drain eSPI 33MHz selected eSPI up to 20MHz supported Maximum Wait state: 0
BUG=b:187122344, b:186135022 TEST=Boot guybrush
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I1a2382d8ab3d3f0d14a139c57470cb895112eca9 --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/52952/1
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 7752eb5..9f077d2 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -693,11 +693,6 @@ ctrlr_config |= ESPI_CRC_CHECKING_EN; }
- if (mb_cfg->dedicated_alert_pin) { - slave_config |= ESPI_SLAVE_ALERT_MODE_PIN; - ctrlr_config |= ESPI_ALERT_MODE; - } - espi_set_io_mode_config(mb_cfg->io_mode, slave_caps, &slave_config, &ctrlr_config); espi_set_op_freq_config(mb_cfg->op_freq_mhz, slave_caps, &slave_config, &ctrlr_config);
@@ -705,6 +700,8 @@ printk(BIOS_INFO, "Setting general configuration: slave: 0x%x controller: 0x%x\n", slave_config, ctrlr_config);
+ espi_show_slave_general_configuration(slave_config); + if (espi_set_configuration(ESPI_SLAVE_GENERAL_CFG, slave_config) == -1) return -1;