Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39862 )
Change subject: util/sconfig: emit NULL sibling fields ......................................................................
util/sconfig: emit NULL sibling fields
It's helpful to see the sibling field, even when it's NULL, when debugging the static.c output from a devictree.cb file. Ensure the NULL fields are emitted for fullness.
Change-Id: Ib6d5b8164769a6512e762d5a525c7df1f429c866 Signed-off-by: Aaron Durbin adurbin@chromium.org --- M util/sconfig/main.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/39862/1
diff --git a/util/sconfig/main.c b/util/sconfig/main.c index d784642..b48f992 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -832,6 +832,8 @@ fprintf(fil, "\t.link_list = NULL,\n"); if (ptr->sibling) fprintf(fil, "\t.sibling = &%s,\n", ptr->sibling->name); + else + fprintf(fil, "\t.sibling = NULL,\n"); fprintf(fil, "#if !DEVTREE_EARLY\n"); for (pin = 0; pin < 4; pin++) { if (ptr->pci_irq_info[pin].ioapic_irq_pin > 0)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39862 )
Change subject: util/sconfig: emit NULL sibling fields ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39862 )
Change subject: util/sconfig: emit NULL sibling fields ......................................................................
util/sconfig: emit NULL sibling fields
It's helpful to see the sibling field, even when it's NULL, when debugging the static.c output from a devictree.cb file. Ensure the NULL fields are emitted for fullness.
Change-Id: Ib6d5b8164769a6512e762d5a525c7df1f429c866 Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/39862 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M util/sconfig/main.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/util/sconfig/main.c b/util/sconfig/main.c index d784642..b48f992 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -832,6 +832,8 @@ fprintf(fil, "\t.link_list = NULL,\n"); if (ptr->sibling) fprintf(fil, "\t.sibling = &%s,\n", ptr->sibling->name); + else + fprintf(fil, "\t.sibling = NULL,\n"); fprintf(fil, "#if !DEVTREE_EARLY\n"); for (pin = 0; pin < 4; pin++) { if (ptr->pci_irq_info[pin].ioapic_irq_pin > 0)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39862 )
Change subject: util/sconfig: emit NULL sibling fields ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1912 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1911 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1910
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)